From: Anthony Liguori <anthony@codemonkey.ws>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [RfC PATCH] qdev: helper macros for properties
Date: Thu, 16 Jul 2009 22:28:16 -0500 [thread overview]
Message-ID: <4A5FEFD0.3070707@codemonkey.ws> (raw)
In-Reply-To: <200907170123.48369.paul@codesourcery.com>
Paul Brook wrote:
> On Wednesday 15 July 2009, Gerd Hoffmann wrote:
>
>> Hi,
>>
>> New revision of the helper macros for defining properties, going on top
>> of all other qdev patches posted today.
>>
>
> IMO this should have been part of the initial properties rework, not a
> followup change. Use of these macros should not be optional.
>
I agree we want to use macros, but the property stuff is likely going to
keep evolving as we figure out how it should be used. For instance,
post the property rework, there has to be a 1-1 mapping between
properties and variables in state. There were a number of places in the
code where that wasn't always true. A property was expanded to a
different internal representation or in one case, there was no internal
representation at all for a property as there was no internal state.
Conceptually, I think it's hard to figure out what the best policy is
without doing a bunch of conversions.
Regards,
Anthony Liguori
> Paul
>
>
>
prev parent reply other threads:[~2009-07-17 3:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 12:35 [Qemu-devel] [RfC PATCH] qdev: helper macros for properties Gerd Hoffmann
2009-07-17 0:23 ` Paul Brook
2009-07-17 3:17 ` Anthony Liguori
2009-07-17 3:28 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5FEFD0.3070707@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).