From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRe7U-0006zw-Vj
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 23:28:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRe7P-0006zk-GD
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 23:28:23 -0400
Received: from [199.232.76.173] (port=50282 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRe7P-0006zf-Aj
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 23:28:19 -0400
Received: from mail-yx0-f188.google.com ([209.85.210.188]:38749)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MRe7O-0006dT-Vy
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 23:28:19 -0400
Received: by yxe26 with SMTP id 26so982164yxe.4
	for <qemu-devel@nongnu.org>; Thu, 16 Jul 2009 20:28:18 -0700 (PDT)
Message-ID: <4A5FEFD0.3070707@codemonkey.ws>
Date: Thu, 16 Jul 2009 22:28:16 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RfC PATCH] qdev: helper macros for properties
References: <1247661358-5411-1-git-send-email-kraxel@redhat.com>
	<200907170123.48369.paul@codesourcery.com>
In-Reply-To: <200907170123.48369.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Paul Brook wrote:
> On Wednesday 15 July 2009, Gerd Hoffmann wrote:
>   
>>   Hi,
>>
>> New revision of the helper macros for defining properties, going on top
>> of all other qdev patches posted today.
>>     
>
> IMO this should have been part of the initial properties rework, not a 
> followup change. Use of these macros should not be optional.
>   

I agree we want to use macros, but the property stuff is likely going to 
keep evolving as we figure out how it should be used.  For instance, 
post the property rework, there has to be a 1-1 mapping between 
properties and variables in state.  There were a number of places in the 
code where that wasn't always true.  A property was expanded to a 
different internal representation or in one case, there was no internal 
representation at all for a property as there was no internal state.

Conceptually, I think it's hard to figure out what the best policy is 
without doing a bunch of conversions.

Regards,

Anthony Liguori

> Paul
>
>
>