From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRhUi-0001QL-GZ for qemu-devel@nongnu.org; Fri, 17 Jul 2009 03:04:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRhUd-0001NU-AF for qemu-devel@nongnu.org; Fri, 17 Jul 2009 03:04:35 -0400 Received: from [199.232.76.173] (port=49947 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRhUd-0001NK-4b for qemu-devel@nongnu.org; Fri, 17 Jul 2009 03:04:31 -0400 Received: from mx20.gnu.org ([199.232.41.8]:44760) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MRhUc-00056X-C8 for qemu-devel@nongnu.org; Fri, 17 Jul 2009 03:04:30 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MRhUb-0007lK-Fl for qemu-devel@nongnu.org; Fri, 17 Jul 2009 03:04:29 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6H74SoR024618 for ; Fri, 17 Jul 2009 03:04:28 -0400 Message-ID: <4A602234.50208@redhat.com> Date: Fri, 17 Jul 2009 09:03:16 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 4/5] QemuOpts: framework for storing and parsing options. References: <1247756224-19219-1-git-send-email-kraxel@redhat.com> <1247756224-19219-5-git-send-email-kraxel@redhat.com> In-Reply-To: <1247756224-19219-5-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann schrieb: > This stores device parameters in a better way than unparsed strings. > > New types: > QemuOpt - one key-value pair. > QemuOpts - group of key-value pairs, belonging to one > device, i.e. one drive. > QemuOptsList - list of some kind of devices, i.e. all drives. What about having the options typed like I did in qemu-option.[ch]? In general qemu-option seems to do more parsing/checking than QemuOpts does, on the other hand it's not yet generic enough to suit everything. Maybe a combination of both would be the right thing? Kevin