From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRoMY-0002AV-BJ
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:24:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRoMU-00027r-Vx
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:24:38 -0400
Received: from [199.232.76.173] (port=36378 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRoMU-00027l-Mo
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:24:34 -0400
Received: from rv-out-0708.google.com ([209.85.198.246]:1452)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MRoMU-0005Jv-BH
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:24:34 -0400
Received: by rv-out-0708.google.com with SMTP id b17so179052rvf.22
	for <qemu-devel@nongnu.org>; Fri, 17 Jul 2009 07:24:33 -0700 (PDT)
Message-ID: <4A60899E.6020108@codemonkey.ws>
Date: Fri, 17 Jul 2009 09:24:30 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <200907171104.n6HB4EDY011438@d01av04.pok.ibm.com>
In-Reply-To: <200907171104.n6HB4EDY011438@d01av04.pok.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT e813376] Sparc32: fix fdc
	io_base
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Anthony Liguori wrote:
> From: Blue Swirl <blauwirbel@gmail.com>
>
> On some Sparc32 machines, fdc is located above 4G limit, so uint32_t is not
> appropriate type for io_base.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>
> diff --git a/hw/fdc.c b/hw/fdc.c
> index fa154a3..4ad5e5e 100644
> --- a/hw/fdc.c
> +++ b/hw/fdc.c
> @@ -33,6 +33,7 @@
>  #include "qemu-timer.h"
>  #include "isa.h"
>  #include "sysbus.h"
> +#include "qdev-addr.h"
>  
>  /********************************************************/
>  /* debug Floppy devices */
> @@ -1972,7 +1973,7 @@ static SysBusDeviceInfo fdc_info = {
>      .qdev.props = (Property[]) {
>          {
>              .name = "io_base",
> -            .info = &qdev_prop_uint32,
> +            .info = &qdev_prop_taddr,
>   

fdc probably shouldn't use target_phys_addr_t and instead should just 
use a uint64_t for io_base.  target_phys is a CPU type, devices 
shouldn't depend on it.

What do you think?

Regards,

Anthony Liguori