From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSCew-0000nZ-Eu for qemu-devel@nongnu.org; Sat, 18 Jul 2009 12:21:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSCeq-0000en-DU for qemu-devel@nongnu.org; Sat, 18 Jul 2009 12:21:12 -0400 Received: from [199.232.76.173] (port=44789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSCeq-0000ea-9s for qemu-devel@nongnu.org; Sat, 18 Jul 2009 12:21:08 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:53762) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MSCep-0004tH-V2 for qemu-devel@nongnu.org; Sat, 18 Jul 2009 12:21:08 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6IGCo01003091 for ; Sat, 18 Jul 2009 10:12:50 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6IGKuvL251968 for ; Sat, 18 Jul 2009 10:20:56 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6IGKtwq006881 for ; Sat, 18 Jul 2009 10:20:55 -0600 Message-ID: <4A61F666.2000209@us.ibm.com> Date: Sat, 18 Jul 2009 11:20:54 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1247892434-21209-1-git-send-email-glommer@redhat.com> In-Reply-To: <1247892434-21209-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] update server bits on vnc_update List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel@nongnu.org, Gerd Hoffmann Glauber Costa wrote: > Since the server/guest split in vnc architecture, we > no longer update the server bits on large updates. Result > is screen gets garbled, specially on scroll actions. > > I must admit I don't fully understand our vnc code, but after > a careful reading, it seemed to me the proposed patch would fix > it, and it indeed, works. > > Gerd, Anthony, please tell me what you think of this approach. > It seems to look reasonable to me but I'd like Gerd to comment too. > This fixes the following bugs for me: > https://bugzilla.redhat.com/show_bug.cgi?id=503156 > https://bugzilla.redhat.com/show_bug.cgi?id=507626 > https://bugs.launchpad.net/qemu/+bug/397212 > Very nice. > Signed-off-by: Glauber Costa > CC: Gerd Hoffmann > --- > vnc.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/vnc.c b/vnc.c > index de0ff87..acebdaf 100644 > --- a/vnc.c > +++ b/vnc.c > @@ -262,9 +262,8 @@ static inline int vnc_and_bits(const uint32_t *d1, const uint32_t *d2, > return 0; > } > > -static void vnc_update(VncState *vs, int x, int y, int w, int h) > +static void do_vnc_update(struct VncSurface *s, int x, int y, int w, int h) > { > - struct VncSurface *s = &vs->guest; > Not worth spinning a new patch, but it's nice to avoid these sort of changes in a bug fix. -- Regards, Anthony Liguori