From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MT9VU-0005ip-RX
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:11:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MT9VQ-0005iQ-EZ
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:11:24 -0400
Received: from [199.232.76.173] (port=52738 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MT9VQ-0005iM-7v
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:11:20 -0400
Received: from mx20.gnu.org ([199.232.41.8]:56931)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1MT9VP-0003Ct-L4
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:11:19 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MT9VN-0008Pu-Ky
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:11:18 -0400
Message-ID: <4A656A0A.8030305@redhat.com>
Date: Tue, 21 Jul 2009 09:11:06 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev/isa: add isa bus support to qdev.
References: <1247662614-12927-1-git-send-email-kraxel@redhat.com>	
	<1247662614-12927-2-git-send-email-kraxel@redhat.com>
	<5b31733c0907171112w73296a4fp12bf5dfc250aa241@mail.gmail.com>
In-Reply-To: <5b31733c0907171112w73296a4fp12bf5dfc250aa241@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 07/17/09 20:12, Filip Navara wrote:
> 2009/7/15 Gerd Hoffmann<kraxel@redhat.com>:
>> +static struct BusInfo isa_bus_info = {
>> +    .name  = "ISA",
>> +    .size  = sizeof(ISABus),
>> +    .props = (Property[]) {
>> +        {
>> +            .name   = "iobase",
>> +            .name   = "iobase2",
>
> Why exactly two IO bases? That sounds like bad design to me. IMHO it
> should be handled more like sysbus_init_mmio (or sysbus_init_mmio_cb)
> and sysbus_mmio_map and the number of IO bases should be virtually
> unlimited (something like QDEV_MAX_MMIO is acceptable).

Do we really need that?  As new isa devices most likely wouldn't show up 
looking at the existing ones should give us a pretty complete picture ;)

Most devices use one iobase.  A few (ide, ps/2) need two.  Any devices 
which need more?

cheers,
   Gerd