From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MT9h8-0002eu-EL for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:23:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MT9h2-0002dc-Pl for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:23:25 -0400 Received: from [199.232.76.173] (port=45257 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MT9h2-0002dZ-KM for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:23:20 -0400 Received: from mx20.gnu.org ([199.232.41.8]:60051) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MT9h2-0005vH-8K for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:23:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MT9h1-0000vO-6m for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:23:19 -0400 Message-ID: <4A656C9C.6020905@redhat.com> Date: Tue, 21 Jul 2009 09:22:04 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu-io: Rework alloc command References: <1248101323-10261-1-git-send-email-kwolf@redhat.com> <20090720205431.GA10205@lst.de> In-Reply-To: <20090720205431.GA10205@lst.de> Content-Type: multipart/mixed; boundary="------------070205020606080609010202" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------070205020606080609010202 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Christoph Hellwig schrieb: > On Mon, Jul 20, 2009 at 04:48:43PM +0200, Kevin Wolf wrote: >> The alloc command in qemu-io is mostly useless currently. Instead of doing a >> single call to bdrv_is_allocated, we must call bdrv_is_allocated in a loop >> until we have found out for each requested sector if it is allocated or not >> (bdrv_is_allocated returns a number of sectors that are known to be in the same >> state as the first one, but it is not required to include all of them) >> >> This changes the output format of the alloc command so that a change to the >> expected output of qemu-iotests 019 is necessary once this is included. > > Looks good to me. Can you post the corresponding qemu-iotests patch, > too? I wanted to post it when the qemu-io change is in, but if you want to apply it earlier (makes qcow2 and vmdk fail until the qemu-io patch is committed), here is it. Kevin --------------070205020606080609010202 Content-Type: text/plain; name="0001-qemu-iotests-Fix-expected-result-for-019-after-qemu.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-qemu-iotests-Fix-expected-result-for-019-after-qemu.pat"; filename*1="ch" >>From 41f80a74b4177e5396dab7916f8f7b40a65cef07 Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Tue, 21 Jul 2009 09:16:37 +0200 Subject: [PATCH] qemu-iotests: Fix expected result for 019 after qemu-io change The output of the alloc command in qemu-io has changed. Signed-off-by: Kevin Wolf --- 019.out | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/019.out b/019.out index f461f8b..9ac1a21 100644 --- a/019.out +++ b/019.out @@ -539,8 +539,8 @@ qemu-io> wrote 65536/65536 bytes at offset 4296146944 qemu-io> No errors were found on the image. Checking if backing clusters are allocated when they shouldn't -qemu-io> 128/128 sectors not allocated at offset 1 MiB -qemu-io> qemu-io> 128/128 sectors not allocated at offset 4.001 GiB +qemu-io> 0/128 sectors allocated at offset 1 MiB +qemu-io> qemu-io> 0/128 sectors allocated at offset 4.001 GiB qemu-io> Reading === IO: pattern 0 -- 1.6.0.6 --------------070205020606080609010202--