From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTGeS-0004RF-5v for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:49:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTGeN-0004PG-Kn for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:49:07 -0400 Received: from [199.232.76.173] (port=39413 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTGeN-0004P4-Eb for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:49:03 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42599) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTGeL-0004XC-Vi for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:49:02 -0400 Message-ID: <4A65D4DD.1040603@redhat.com> Date: Tue, 21 Jul 2009 16:46:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1247841685-18495-1-git-send-email-aliguori@us.ibm.com> <1247841685-18495-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1247841685-18495-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Paul Brook On 07/17/09 16:41, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori Hmm, I think that goes into the wrong direction. Properties should not be pointers to internal qemu state. Yes, there is qemu_prop_ptr, but I consider that a temporary stopgap until we can do better. Instead CharDriverState's should get a name and we need a way to lookup them by name. Then we can store the name instead of a pointer into the property. cheers, Gerd