From: Anthony Liguori <aliguori@us.ibm.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type
Date: Tue, 21 Jul 2009 09:53:42 -0500 [thread overview]
Message-ID: <4A65D676.9050406@us.ibm.com> (raw)
In-Reply-To: <4A65D4DD.1040603@redhat.com>
Gerd Hoffmann wrote:
> On 07/17/09 16:41, Anthony Liguori wrote:
>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
> Hmm, I think that goes into the wrong direction. Properties should
> not be pointers to internal qemu state. Yes, there is qemu_prop_ptr,
> but I consider that a temporary stopgap until we can do better.
> Instead CharDriverState's should get a name and we need a way to
> lookup them by name. Then we can store the name instead of a pointer
> into the property.
Would you have a property type that was basically a char driver state name?
> cheers,
> Gerd
>
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-07-21 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 14:41 [Qemu-devel] [PATCH 0/2][RFC] Introduce macros for setting properties Anthony Liguori
2009-07-17 14:41 ` [Qemu-devel] [PATCH 1/2] Introduce CharDriverState qdev property type Anthony Liguori
2009-07-21 14:46 ` [Qemu-devel] " Gerd Hoffmann
2009-07-21 14:53 ` Anthony Liguori [this message]
2009-07-21 15:03 ` Gerd Hoffmann
2009-07-21 15:14 ` Gerd Hoffmann
2009-07-21 15:23 ` Anthony Liguori
2009-07-21 15:34 ` Gerd Hoffmann
2009-07-21 15:47 ` Anthony Liguori
2009-07-22 9:48 ` Gerd Hoffmann
2009-07-17 14:41 ` [Qemu-devel] [PATCH 2/2] Introduce macro for defining qdev properties Anthony Liguori
2009-07-17 17:23 ` Blue Swirl
2009-07-17 17:26 ` Anthony Liguori
2009-07-17 17:33 ` Paul Brook
2009-07-17 18:11 ` Anthony Liguori
2009-07-17 18:32 ` Blue Swirl
2009-07-17 20:05 ` Anthony Liguori
2009-07-17 22:58 ` Paul Brook
2009-07-18 12:43 ` Jamie Lokier
2009-07-18 16:13 ` Anthony Liguori
2009-07-20 2:29 ` Jamie Lokier
2009-07-21 8:30 ` [Qemu-devel] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A65D676.9050406@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).