From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTGkB-0002HK-2e for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:55:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTGk6-000285-GQ for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:55:02 -0400 Received: from [199.232.76.173] (port=38372 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTGk6-00027T-1T for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:54:58 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:51636) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTGk5-0006wA-FY for qemu-devel@nongnu.org; Tue, 21 Jul 2009 10:54:57 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n6LEmZw7001255 for ; Tue, 21 Jul 2009 10:48:35 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6LErjYU212254 for ; Tue, 21 Jul 2009 10:53:45 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6LEriGO026838 for ; Tue, 21 Jul 2009 10:53:45 -0400 Message-ID: <4A65D676.9050406@us.ibm.com> Date: Tue, 21 Jul 2009 09:53:42 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1247841685-18495-1-git-send-email-aliguori@us.ibm.com> <1247841685-18495-2-git-send-email-aliguori@us.ibm.com> <4A65D4DD.1040603@redhat.com> In-Reply-To: <4A65D4DD.1040603@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Paul Brook Gerd Hoffmann wrote: > On 07/17/09 16:41, Anthony Liguori wrote: > >> Signed-off-by: Anthony Liguori > > Hmm, I think that goes into the wrong direction. Properties should > not be pointers to internal qemu state. Yes, there is qemu_prop_ptr, > but I consider that a temporary stopgap until we can do better. > Instead CharDriverState's should get a name and we need a way to > lookup them by name. Then we can store the name instead of a pointer > into the property. Would you have a property type that was basically a char driver state name? > cheers, > Gerd > -- Regards, Anthony Liguori