From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MTGux-0006tB-Rm
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:06:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MTGus-0006sa-S8
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:06:11 -0400
Received: from [199.232.76.173] (port=39938 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MTGus-0006sX-LJ
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:06:06 -0400
Received: from mx2.redhat.com ([66.187.237.31]:33345)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MTGur-0001Vz-97
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:06:06 -0400
Message-ID: <4A65D8CA.20004@redhat.com>
Date: Tue, 21 Jul 2009 17:03:38 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1247841685-18495-1-git-send-email-aliguori@us.ibm.com>
	<1247841685-18495-2-git-send-email-aliguori@us.ibm.com>
	<4A65D4DD.1040603@redhat.com> <4A65D676.9050406@us.ibm.com>
In-Reply-To: <4A65D676.9050406@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev
	property type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

On 07/21/09 16:53, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> On 07/17/09 16:41, Anthony Liguori wrote:
>>
>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>
>> Hmm, I think that goes into the wrong direction. Properties should not
>> be pointers to internal qemu state. Yes, there is qemu_prop_ptr, but I
>> consider that a temporary stopgap until we can do better.
>> Instead CharDriverState's should get a name and we need a way to
>> lookup them by name. Then we can store the name instead of a pointer
>> into the property.
>
> Would you have a property type that was basically a char driver state name?

Yes.  Same for drives and others.  A generic string property should do I 
think.

cheers,
   Gerd