From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTHCD-00050x-FH for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:24:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTHC9-0004yu-QZ for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:24:01 -0400 Received: from [199.232.76.173] (port=57230 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTHC9-0004yp-OY for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:23:57 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:34897) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTHC9-0004va-Bu for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:23:57 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e32.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6LFJiSk006704 for ; Tue, 21 Jul 2009 09:19:44 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6LFNghY156944 for ; Tue, 21 Jul 2009 09:23:44 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6LFNgFc009882 for ; Tue, 21 Jul 2009 09:23:42 -0600 Message-ID: <4A65DD7C.3090902@us.ibm.com> Date: Tue, 21 Jul 2009 10:23:40 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1247841685-18495-1-git-send-email-aliguori@us.ibm.com> <1247841685-18495-2-git-send-email-aliguori@us.ibm.com> <4A65D4DD.1040603@redhat.com> <4A65D676.9050406@us.ibm.com> <4A65D8CA.20004@redhat.com> In-Reply-To: <4A65D8CA.20004@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Paul Brook Gerd Hoffmann wrote: > On 07/21/09 16:53, Anthony Liguori wrote: >> Gerd Hoffmann wrote: >>> On 07/17/09 16:41, Anthony Liguori wrote: >>> >>>> Signed-off-by: Anthony Liguori >>> >>> Hmm, I think that goes into the wrong direction. Properties should not >>> be pointers to internal qemu state. Yes, there is qemu_prop_ptr, but I >>> consider that a temporary stopgap until we can do better. >>> Instead CharDriverState's should get a name and we need a way to >>> lookup them by name. Then we can store the name instead of a pointer >>> into the property. >> >> Would you have a property type that was basically a char driver state >> name? > > Yes. Same for drives and others. A generic string property should do > I think. Couldn't a struct pointer be used for that though? It can still be exposed as a string to the user. > cheers, > Gerd > -- Regards, Anthony Liguori