From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTHOv-000511-1M for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:37:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTHOq-0004sE-4V for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:37:08 -0400 Received: from [199.232.76.173] (port=41611 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTHOo-0004qC-IX for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:37:02 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36001) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTHOn-0007Kp-TR for qemu-devel@nongnu.org; Tue, 21 Jul 2009 11:37:02 -0400 Message-ID: <4A65E01E.8010505@redhat.com> Date: Tue, 21 Jul 2009 17:34:54 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1247841685-18495-1-git-send-email-aliguori@us.ibm.com> <1247841685-18495-2-git-send-email-aliguori@us.ibm.com> <4A65D4DD.1040603@redhat.com> <4A65D676.9050406@us.ibm.com> <4A65D8CA.20004@redhat.com> <4A65DD7C.3090902@us.ibm.com> In-Reply-To: <4A65DD7C.3090902@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Paul Brook On 07/21/09 17:23, Anthony Liguori wrote: > Gerd Hoffmann wrote: >>> Would you have a property type that was basically a char driver state >>> name? >> >> Yes. Same for drives and others. A generic string property should do I >> think. > > Couldn't a struct pointer be used for that though? It can still be > exposed as a string to the user. Hmm, didn't think about that possibility. Somehow makes sense as it would move the lookup-by-name into generic code (i.e. qemu_prop_chardev->parse). Not sure what qdev_prop_set_chrdev() should accept then. struct pointer? string? cheers, Gerd