From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MTOFM-0002Ql-JF
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 18:55:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MTOFH-0002Q6-3O
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 18:55:43 -0400
Received: from [199.232.76.173] (port=58296 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MTOFG-0002Q3-UF
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 18:55:38 -0400
Received: from mail-gx0-f220.google.com ([209.85.217.220]:41283)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MTOFG-0007qV-JR
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 18:55:38 -0400
Received: by gxk20 with SMTP id 20so16297381gxk.10
	for <qemu-devel@nongnu.org>; Tue, 21 Jul 2009 15:55:37 -0700 (PDT)
Message-ID: <4A664760.3070006@codemonkey.ws>
Date: Tue, 21 Jul 2009 17:55:28 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/7] Set slots more carefully
References: <1247831508-19023-1-git-send-email-agraf@suse.de>	<1247831508-19023-2-git-send-email-agraf@suse.de>	<1247831508-19023-3-git-send-email-agraf@suse.de>	<1247831508-19023-4-git-send-email-agraf@suse.de>	<1247831508-19023-5-git-send-email-agraf@suse.de>	<1247831508-19023-6-git-send-email-agraf@suse.de>
	<1247831508-19023-7-git-send-email-agraf@suse.de>
In-Reply-To: <1247831508-19023-7-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, hollisb@us.ibm.com

Alexander Graf wrote:
> KVM only supports slot sizes of PAGE_SIZE granilarity. On PPC the OS
> sets the framebuffer to some odd size though, causing the current code
> to simply abort().
>   

Why is the caller registering a memory region that isn't PAGE_SIZE?  Is 
it relying on subpage memory registration?

If so, this isn't something we handle in KVM today.

If the PPC framebuffer is just being registered with the wrong size, I'd 
rather see that fixed.

Regards,

Anthony Liguori