From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTOY6-0002FB-PL for qemu-devel@nongnu.org; Tue, 21 Jul 2009 19:15:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTOY2-0002Es-G4 for qemu-devel@nongnu.org; Tue, 21 Jul 2009 19:15:06 -0400 Received: from [199.232.76.173] (port=51275 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTOY2-0002Ep-DL for qemu-devel@nongnu.org; Tue, 21 Jul 2009 19:15:02 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:41441) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTOY1-0002Xl-R3 for qemu-devel@nongnu.org; Tue, 21 Jul 2009 19:15:02 -0400 Message-ID: <4A664BF4.3040404@web.de> Date: Wed, 22 Jul 2009 01:15:00 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20090721143936.GA18061@amd.home.annexia.org> <4A65FD5B.6050509@siemens.com> <20090721161642.GA18957@amd.home.annexia.org> <4A65EAB6.3060006@siemens.com> <20090721192311.GG9230@amd.home.annexia.org> In-Reply-To: <20090721192311.GG9230@amd.home.annexia.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8003305068C8D556B967B08F" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: guestfwd option doesn't allow supplementary , server, nowait List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8003305068C8D556B967B08F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Richard W.M. Jones wrote: > On Tue, Jul 21, 2009 at 06:20:06PM +0200, Jan Kiszka wrote: >> So this particular issue is (also?) a -stable regression? That should = be >> easily bisectible. >=20 > This is what git-bisect said: >=20 > c92ef6a22d3c71538fcc48fb61ad353f7ba03b62 is first bad commit > commit c92ef6a22d3c71538fcc48fb61ad353f7ba03b62 > Author: Jan Kiszka > Date: Wed Jun 24 14:42:28 2009 +0200 > =20 > slirp: Rework external configuration interface > =20 > With the internal IP configuration made more flexible, we can now= > enhance the user interface. This patch adds a number of new optio= ns to > "-net user": net (address and mask), host, dhcpstart, dns and smb= server. > It also renames "redir" to "hostfwd" and "channel" to "guestfwd" = in > order to (hopefully) clarify their meanings. The format of guestf= wd is > extended so that the user can define not only the port but also t= he > virtual server's IP address the forwarding starts from. > =20 > Signed-off-by: Jan Kiszka > Signed-off-by: Anthony Liguori > =20 > :100644 100644 18c51190bf5ff20625ecaf3de45bd4aab4403044 f26c3f804ec5d= 234f76e14200e1188d21923a732 M net.c > :100644 100644 d1c1539e21caf9da16ef1cd68e29976d1abf576f da5b0ac6a5034= 45431f966de37be0ed3440c6225 M qemu-options.hx > :040000 040000 e371676d54aea53190c3ab3fb36a2d9d8da97ded af6ed9e3cc7c6= 50828315f836615ffdb829b02a3 M slirp >=20 > I have stared at the code for quite a while and I don't see the error. That commit is not from stable, but from 0.11 (and it is expected to introduce the regression for that series). You are confusing me: Are you actually seeing a regression with *0.10.5*? >=20 > As another data point: I added some fprintf's to guestfwd_can_read and > guestfwd_read and I can tell you that guestfwd_can_read is called > continually (returning 0 each time), while guestfwd_read is never > called. Can't tell, need to check the code in more details. Was the corresponding vmchannel handler called properly in 0.10.x? Jan --------------enig8003305068C8D556B967B08F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpmS/QACgkQniDOoMHTA+mA5wCdHNKgaAm2Y1U1RZHezpRvbq+H bHMAn2vjiAspBf/MPo4VYembnQqYm63U =Nb6x -----END PGP SIGNATURE----- --------------enig8003305068C8D556B967B08F--