From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTf2o-0004IN-0b for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:51:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTf2k-000462-5U for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:51:53 -0400 Received: from [199.232.76.173] (port=38768 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTf2j-00045j-Ks for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:51:49 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:19731) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTf2i-0004Fy-Nl for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:51:49 -0400 Message-ID: <4A67439D.7010301@siemens.com> Date: Wed, 22 Jul 2009 18:51:41 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1247831508-19023-1-git-send-email-agraf@suse.de> <1247831508-19023-2-git-send-email-agraf@suse.de> <1247831508-19023-3-git-send-email-agraf@suse.de> <1247831508-19023-4-git-send-email-agraf@suse.de> <4A673180.4030108@codemonkey.ws> <1248278346.4521.5.camel@slab.beaverton.ibm.com> <4A673CBE.8040003@codemonkey.ws> <1248279975.16442.2.camel@slab.beaverton.ibm.com> In-Reply-To: <1248279975.16442.2.camel@slab.beaverton.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hollis Blanchard Cc: Alexander Graf , qemu-devel@nongnu.org Hollis Blanchard wrote: > On Wed, 2009-07-22 at 11:22 -0500, Anthony Liguori wrote: >> Hollis Blanchard wrote: >>> On Wed, 2009-07-22 at 10:34 -0500, Anthony Liguori wrote: >>> >>>> Alexander Graf wrote: >>>> >>>>> Some generic code tries to access env->mp_state. Let's just make >>>>> it happy and provide it. >>>>> >>>>> Signed-off-by: Alexander Graf >>>>> >>>>> >>>> Or we can move that code from kvm-all.c to target-i386/kvm.c where it >>>> belongs :-) >>>> >>> Common code uses mp_state, and i386 is the only thing calling that code. >>> However, the ioctl used by that code is valid for all architectures; it >>> will just return -EINVAL. Someday we might need it in common code, but >>> then again it's not even clear to me it will be useful outside of x86. >>> >>> I'm fine with moving it too, as long as it's also renamed at the same >>> time. :) >>> >> Why is it a common ioctl instead of an arch specific ioctl? > > I can only speculate: Marcelo probably thought other architectures may > have something useful to put there. > mp_state is also used by (yet unsupported) ia64. So I think it's better to keep the related bits in the arch-independent part. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux