From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MThVR-0006YV-Jn
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:29:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MThVN-0006Xo-2G
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:29:37 -0400
Received: from [199.232.76.173] (port=56661 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MThVM-0006Xl-VR
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:29:32 -0400
Received: from e2.ny.us.ibm.com ([32.97.182.142]:35163)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1MThVM-0002xv-BM
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:29:32 -0400
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6MJO6Sj029432
	for <qemu-devel@nongnu.org>; Wed, 22 Jul 2009 15:24:06 -0400
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	n6MJTTsK256030
	for <qemu-devel@nongnu.org>; Wed, 22 Jul 2009 15:29:30 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n6MJTTRA027787
	for <qemu-devel@nongnu.org>; Wed, 22 Jul 2009 15:29:29 -0400
Message-ID: <4A676897.5070200@us.ibm.com>
Date: Wed, 22 Jul 2009 14:29:27 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <200907221626.n6MGQGH0022104@d03av02.boulder.ibm.com>
	<4A6745C0.5060201@siemens.com> <4A675758.2080302@codemonkey.ws>
	<4A676839.8050500@web.de>
In-Reply-To: <4A676839.8050500@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] kvm: Fix error detection for
	KVM_GET_DIRTY_LOG
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

Jan Kiszka wrote:
> ----------->
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
>  kvm-all.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 824bb4c..53925be 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -348,7 +348,9 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
>          d.slot = mem->slot;
>  
>          r = kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d);
> -        if (r == -EINVAL) {
> +        /* KVM for PowerPC returns illicit -ENOTSUPP (-524) which we handle
> +         * below. */
> +        if (r < 0 && r != -524) {
>   

That makes me uncomfortable.  Shouldn't we make kvm return something 
that's exposed to userspace?

-- 
Regards,

Anthony Liguori