From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MThg4-0000f6-F3
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:40:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MThfz-0000dT-7H
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:40:35 -0400
Received: from [199.232.76.173] (port=33902 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MThfx-0000dD-M1
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:40:30 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:59484)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MThfw-0004lK-W4
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:40:29 -0400
Message-ID: <4A676B27.10100@web.de>
Date: Wed, 22 Jul 2009 21:40:23 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <200907221626.n6MGQGH0022104@d03av02.boulder.ibm.com>
	<4A6745C0.5060201@siemens.com> <4A675758.2080302@codemonkey.ws>
	<4A676839.8050500@web.de> <4A676897.5070200@us.ibm.com>
In-Reply-To: <4A676897.5070200@us.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig94B85C71EE1B34222C57C346"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] kvm: Fix error detection for
	KVM_GET_DIRTY_LOG
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig94B85C71EE1B34222C57C346
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> ----------->
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>>  kvm-all.c |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/kvm-all.c b/kvm-all.c
>> index 824bb4c..53925be 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -348,7 +348,9 @@ int
>> kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
>>          d.slot =3D mem->slot;
>> =20
>>          r =3D kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d);
>> -        if (r =3D=3D -EINVAL) {
>> +        /* KVM for PowerPC returns illicit -ENOTSUPP (-524) which we
>> handle
>> +         * below. */
>> +        if (r < 0 && r !=3D -524) {
>>  =20
>=20
> That makes me uncomfortable.  Shouldn't we make kvm return something
> that's exposed to userspace?
>=20

Yes, but we can't do this from user space :) (or in other words: there
are already kernels out there which return this invalid code).

The situation would only be different if Alex said that it takes further
kernel patches anyway to make his PowerPC targets work. Dunno.

Jan


--------------enig94B85C71EE1B34222C57C346
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkpnaysACgkQniDOoMHTA+nZtgCfXnP+Je1XBSXisgVzD2ikSfpL
FeIAn2oKj+Ux1e1HWXROhtS4hqtRwYBv
=lIVx
-----END PGP SIGNATURE-----

--------------enig94B85C71EE1B34222C57C346--