From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MThpb-0004XS-74 for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:50:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MThpV-0004U2-CB for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:50:25 -0400 Received: from [199.232.76.173] (port=36914 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MThpU-0004Tk-Ph for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:50:20 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:39320) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MThpU-0006ck-8P for qemu-devel@nongnu.org; Wed, 22 Jul 2009 15:50:20 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n6MJcqEs015510 for ; Wed, 22 Jul 2009 13:38:52 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6MJgMaA171360 for ; Wed, 22 Jul 2009 13:42:23 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6MJgMQk024534 for ; Wed, 22 Jul 2009 13:42:22 -0600 Message-ID: <4A676B98.1060104@us.ibm.com> Date: Wed, 22 Jul 2009 14:42:16 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <200907221626.n6MGQGH0022104@d03av02.boulder.ibm.com> <4A6745C0.5060201@siemens.com> <4A675758.2080302@codemonkey.ws> <4A676839.8050500@web.de> <4A676897.5070200@us.ibm.com> <4A676B27.10100@web.de> In-Reply-To: <4A676B27.10100@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Alexander Graf Jan Kiszka wrote: >> That makes me uncomfortable. Shouldn't we make kvm return something >> that's exposed to userspace? >> >> > > Yes, but we can't do this from user space :) (or in other words: there > are already kernels out there which return this invalid code). > But since it's not symbolic, at some point in time the meaning of 524 can potentially change and introduce a very, very subtle bug. > The situation would only be different if Alex said that it takes further > kernel patches anyway to make his PowerPC targets work. Dunno. > Certainly, his PPC target is not in any released kernel version so there's time to fix things properly. > Jan > > -- Regards, Anthony Liguori