From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTi5P-0000P9-Uw for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:06:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTi5L-0000Oc-6a for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:06:47 -0400 Received: from [199.232.76.173] (port=38852 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTi5L-0000OZ-2S for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:06:43 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:50068) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTi5K-0002Cm-4P for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:06:42 -0400 Message-ID: <4A6770EB.7090301@web.de> Date: Wed, 22 Jul 2009 22:04:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1248285441.30567.12.camel@localhost.localdomain> <4A67610F.5090204@web.de> <1248291957.3841.10.camel@localhost.localdomain> In-Reply-To: <1248291957.3841.10.camel@localhost.localdomain> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD8CFE770F7FB1AB067CD7FEA" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] slirp: Read host DNS config on demand List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ed Swierk Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD8CFE770F7FB1AB067CD7FEA Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Ed Swierk wrote: > On Wed, 2009-07-22 at 20:57 +0200, Jan Kiszka wrote: >> Nice. I noticed this, too, and shortly thought about some possible >> fixes. Don't know why I dropped it again. Anyway, your approach looks >> straightforward. Please rebase over git head, and I will happily test >> and ack it! >=20 > FYI there are two other things that tend to break on laptops especially= : >=20 > - If the system clock jumps backwards, functions that rely on > gettimeofday() for computing a time interval get confused. > gettimeofday() should be replaced with clock_gettime(CLOCK_MONOTONIC). > Hopefully all Unixy platforms support it? You mean that gettimeofday in updtime? Yes, that's only for timeout calculation IIRC and should be converted. Patch welcome. Are there more? I didn't find any on quick scan. >=20 > - Storing the address of some random host interface in our_addr is bad > for the same reason as storing the address of the DNS server. > Fortunately most references to our_addr are in dead code, and the > remaining ones are questionable. True. I shortly thought about ripping all those historic UDP protocol emulations out, but then I didn't feel brave enough. I couldn't asses if they are still of any use for some qemu people (namely it's CUSEEME, the rest is disabled anyway). But maybe it's worth posting another cleanup patch. >=20 > Anyway, here's the updated patch for the DNS issue. Thanks, will test. Jan --------------enigD8CFE770F7FB1AB067CD7FEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpncPMACgkQniDOoMHTA+lgMgCfWsFlbhJxf+qPMGGam8uCzs8j upUAn13mF3Uy9W2Na3QctL0DDDMkKte6 =SvRN -----END PGP SIGNATURE----- --------------enigD8CFE770F7FB1AB067CD7FEA--