From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTi6g-00010K-MV for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:08:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTi6c-0000zh-01 for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:08:06 -0400 Received: from [199.232.76.173] (port=38868 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTi6b-0000zZ-RE for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:08:01 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:35104) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTi6b-0002RS-87 for qemu-devel@nongnu.org; Wed, 22 Jul 2009 16:08:01 -0400 Message-ID: <4A67719F.9040803@web.de> Date: Wed, 22 Jul 2009 22:07:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <200907221626.n6MGQGH0022104@d03av02.boulder.ibm.com> <4A6745C0.5060201@siemens.com> <4A675758.2080302@codemonkey.ws> <4A676839.8050500@web.de> <4A676897.5070200@us.ibm.com> <4A676B27.10100@web.de> <4A676B98.1060104@us.ibm.com> In-Reply-To: <4A676B98.1060104@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8590FEBAB32B117671A86528" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel , Alexander Graf This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8590FEBAB32B117671A86528 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Jan Kiszka wrote: >>> That makes me uncomfortable. Shouldn't we make kvm return something >>> that's exposed to userspace? >>> >>> =20 >> >> Yes, but we can't do this from user space :) (or in other words: there= >> are already kernels out there which return this invalid code). >> =20 >=20 > But since it's not symbolic, at some point in time the meaning of 524 > can potentially change and introduce a very, very subtle bug. I won't change in old kernel versions, and I expect someone from the Powe= rPC folks to fix it for new version fairly soon. >=20 >> The situation would only be different if Alex said that it takes furth= er >> kernel patches anyway to make his PowerPC targets work. Dunno. >> =20 >=20 > Certainly, his PPC target is not in any released kernel version so > there's time to fix things properly. Ah, ok. Then let's do this (Alex can carry a temporary workaround locally IMHO): -------------> Signed-off-by: Jan Kiszka --- kvm-all.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 824bb4c..5fb8dba 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -348,7 +348,7 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t= start_addr, d.slot =3D mem->slot; =20 r =3D kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d); - if (r =3D=3D -EINVAL) { + if (r < 0) { dprintf("ioctl failed %d\n", errno); ret =3D -1; break; --------------enig8590FEBAB32B117671A86528 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpncZ8ACgkQniDOoMHTA+mP7gCdHo5xe2SrohTggEawfrU2SJYN /A4An1s58AcoL6NXapoB969s7lfeTdJj =hY2a -----END PGP SIGNATURE----- --------------enig8590FEBAB32B117671A86528--