qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Check availability of uuid header / lib
Date: Wed, 22 Jul 2009 22:43:56 +0200	[thread overview]
Message-ID: <4A677A0C.6050700@mail.berlios.de> (raw)
In-Reply-To: <1246655510-7141-1-git-send-email-weil@mail.berlios.de>

Stefan Weil schrieb:
> The Universally Unique Identifier library will be used
> for the new vdi block driver and maybe other parts of QEMU.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> Makefile | 1 +
> Makefile.target | 2 ++
> configure | 21 +++++++++++++++++++++
> 3 files changed, 24 insertions(+), 0 deletions(-)
...


That patch no longer applies without merge conflicts.

I just noticed that there was a discussion a year ago
when other developers suggested to use libuuid.

We can see the result of that discussion in the current code:
QEMU does not use libuuid, not even functions with the
same interface. Nor does it include a function to generate
a new UUID value.

There were arguments why QEMU would not need
UUID generation in its code. The VDI block driver
needs UUID generation unless we are satisfied with
dummy or zero values.

My personal preference is using libuuid and the functions
included. For systems without libuuid, a minimalistic
implementation could be provided.

Before I send an update of my patch, I'd like to hear
the opinion of others, especially of the QEMU maintainers.

Regards,
Stefan Weil

  reply	other threads:[~2009-07-22 21:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m3my7lv954.fsf@neno.mitica>
2009-07-03 21:11 ` [Qemu-devel] [PATCH] Check availability of uuid header / lib Stefan Weil
2009-07-22 20:43   ` Stefan Weil [this message]
2009-07-22 21:41     ` Anthony Liguori
2009-07-23 15:49       ` Stefan Weil
2009-07-23 15:58 [Qemu-devel] [PATCH] RFC: Add new block driver for the VDI format (aio version) Stefan Weil
2009-07-23 20:27 ` [Qemu-devel] [PATCH] Check availability of uuid header / lib Stefan Weil
2009-07-24  6:32   ` Christoph Egger
2009-10-01 18:13     ` Stefan Weil
2009-10-02  8:32       ` Christoph Egger
  -- strict thread matches above, loose matches on Subject: below --
2009-07-03 19:24 [Qemu-devel] [PATCH] RFC: Add new block driver for the VDI format Stefan Weil
2009-07-03 19:29 ` [Qemu-devel] [PATCH] Check availability of uuid header / lib Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A677A0C.6050700@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).