From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTizY-0002Qv-DR for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:04:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTizT-0002M3-ON for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:04:47 -0400 Received: from [199.232.76.173] (port=43652 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTizT-0002Lx-9Y for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:04:43 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:58750) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTizS-0004d2-Jt for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:04:42 -0400 Received: from [127.0.0.1] (ident=stefan) by flocke.weilnetz.de with esmtp (Exim 4.69) (envelope-from ) id 1MTifM-0003sD-QF for qemu-devel@nongnu.org; Wed, 22 Jul 2009 22:43:56 +0200 Message-ID: <4A677A0C.6050700@mail.berlios.de> Date: Wed, 22 Jul 2009 22:43:56 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Check availability of uuid header / lib References: <1246655510-7141-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1246655510-7141-1-git-send-email-weil@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Stefan Weil schrieb: > The Universally Unique Identifier library will be used > for the new vdi block driver and maybe other parts of QEMU. > > Signed-off-by: Stefan Weil > --- > Makefile | 1 + > Makefile.target | 2 ++ > configure | 21 +++++++++++++++++++++ > 3 files changed, 24 insertions(+), 0 deletions(-) ... That patch no longer applies without merge conflicts. I just noticed that there was a discussion a year ago when other developers suggested to use libuuid. We can see the result of that discussion in the current code: QEMU does not use libuuid, not even functions with the same interface. Nor does it include a function to generate a new UUID value. There were arguments why QEMU would not need UUID generation in its code. The VDI block driver needs UUID generation unless we are satisfied with dummy or zero values. My personal preference is using libuuid and the functions included. For systems without libuuid, a minimalistic implementation could be provided. Before I send an update of my patch, I'd like to hear the opinion of others, especially of the QEMU maintainers. Regards, Stefan Weil