From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MTjOF-0003YM-Vj
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:30:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MTjOB-0003W4-Vw
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:30:19 -0400
Received: from [199.232.76.173] (port=38442 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MTjOB-0003Vv-9z
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:30:15 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:46427)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MTjOA-0000dS-Q4
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:30:15 -0400
Message-ID: <4A6784E0.2070701@web.de>
Date: Wed, 22 Jul 2009 23:30:08 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <200907221626.n6MGQGH0022104@d03av02.boulder.ibm.com>
	<4A6745C0.5060201@siemens.com> <4A675758.2080302@codemonkey.ws>
	<4A676839.8050500@web.de> <4A676897.5070200@us.ibm.com>
	<4A676B27.10100@web.de> <4A676B98.1060104@us.ibm.com>
	<4A67719F.9040803@web.de>
	<A902F44E-B102-46AA-B4DC-0D8A01429F64@suse.de>
	<4A678189.1030802@us.ibm.com>
	<137B26C8-A9A7-4253-8977-C43C3CEFD30C@suse.de>
In-Reply-To: <137B26C8-A9A7-4253-8977-C43C3CEFD30C@suse.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig8C91543B454379BE03C8432D"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] kvm: Fix error detection for
	KVM_GET_DIRTY_LOG
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8C91543B454379BE03C8432D
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Alexander Graf wrote:
>=20
> Am 22.07.2009 um 23:15 schrieb Anthony Liguori <aliguori@us.ibm.com>:
>=20
>> Alexander Graf wrote:
>>>
>>> The only thing I'd agree with as a good idea instead of the version I=

>>> sent is an explicit switch statement with an include of errno.h with
>>> __KERNEL__ set.
>>
>> No way :-)
>>
>> What's the problem with fixing the kernel to return a proper errno?
>=20
> I'd rather do a proper dirty log implementation than that :). But yes,
> you convinced me. I'll just do dirtylogging for ppc.

Puh... :)

>=20
> Now what about ia64?

There is a non-empty kvm_vm_ioctl_get_dirty_log() in kvm-ia64.c.

So I think we can revert your patch and just merge the tiny error-check
fix, right?

Jan


--------------enig8C91543B454379BE03C8432D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkpnhOQACgkQniDOoMHTA+n69QCfXSsObwkLPYNJTznf2NTOE6Sx
6dUAni/+DiWi1DQ1kF5sQVTcPzUXzkU+
=z8wJ
-----END PGP SIGNATURE-----

--------------enig8C91543B454379BE03C8432D--