From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTjZH-0002ZU-U3 for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:41:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTjZC-0002VL-9E for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:41:42 -0400 Received: from [199.232.76.173] (port=45713 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTjZB-0002V2-Sj for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:41:37 -0400 Received: from qw-out-1920.google.com ([74.125.92.150]:18332) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTjZB-0002QA-Jm for qemu-devel@nongnu.org; Wed, 22 Jul 2009 17:41:37 -0400 Received: by qw-out-1920.google.com with SMTP id 5so270013qwc.4 for ; Wed, 22 Jul 2009 14:41:37 -0700 (PDT) Message-ID: <4A67878F.4000907@codemonkey.ws> Date: Wed, 22 Jul 2009 16:41:35 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Check availability of uuid header / lib References: <1246655510-7141-1-git-send-email-weil@mail.berlios.de> <4A677A0C.6050700@mail.berlios.de> In-Reply-To: <4A677A0C.6050700@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers Stefan Weil wrote: > That patch no longer applies without merge conflicts. > > I just noticed that there was a discussion a year ago > when other developers suggested to use libuuid. > > We can see the result of that discussion in the current code: > QEMU does not use libuuid, not even functions with the > same interface. Nor does it include a function to generate > a new UUID value. > > There were arguments why QEMU would not need > UUID generation in its code. The VDI block driver > needs UUID generation unless we are satisfied with > dummy or zero values. > I don't mind linking against libuuid. However, I think the VDI block driver has to support AIO before it can be merged into the tree. Regards, Anthony Liguori