From: Jan Kiszka <jan.kiszka@web.de>
To: Ed Swierk <eswierk@aristanetworks.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] slirp: Use monotonic clock if available
Date: Thu, 23 Jul 2009 08:40:02 +0200 [thread overview]
Message-ID: <4A6805C2.2050405@web.de> (raw)
In-Reply-To: <9ae48b020907221757i50980003u185b18f1c1940295@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
Ed Swierk wrote:
> On Wed, Jul 22, 2009 at 11:38 PM, malc<av1474@comtv.ru> wrote:
>> This is wrong on many levels.
>>
>> Suppose CLOCK_MONOTONIC(which is wrong _POSIX_MONOTONIC_CLOCK ought to
>> be checked) is defined and you compile your binary on, say, Linux 2.6
>> and then try to run it on 2.4 (without any fancy RHEL patches for
>> instance), things wouldn't work, what's worse they wouldn't work
>> silently, giving no indication what's wrong all because nobody checks
>> clock_gettime result for failures.
>>
>> The CLOCK_MONOTONIC presence ought to be checked at runtime
>> (see sysconf(3) and _POSIX_MONOTONIC_CLOCK)
>
> OK, sounds like slirp should just call qemu_get_clock(rt_clock), which
> is supposed to deal with all these complications.
Exactly.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
prev parent reply other threads:[~2009-07-23 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 22:49 [Qemu-devel] [PATCH] slirp: Use monotonic clock if available Ed Swierk
2009-07-22 23:38 ` malc
2009-07-23 0:57 ` Ed Swierk
2009-07-23 6:40 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6805C2.2050405@web.de \
--to=jan.kiszka@web.de \
--cc=eswierk@aristanetworks.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).