From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTryc-0001gk-Cf for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:40:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTryW-0001eL-Hm for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:40:24 -0400 Received: from [199.232.76.173] (port=45772 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTryV-0001dz-RH for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:40:20 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:60886) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTryV-00059p-5Z for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:40:19 -0400 Message-ID: <4A6805C2.2050405@web.de> Date: Thu, 23 Jul 2009 08:40:02 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1248302945.14831.4.camel@localhost.localdomain> <9ae48b020907221757i50980003u185b18f1c1940295@mail.gmail.com> In-Reply-To: <9ae48b020907221757i50980003u185b18f1c1940295@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig96A16FBE99DD7971F00A5736" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] slirp: Use monotonic clock if available List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ed Swierk Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig96A16FBE99DD7971F00A5736 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Ed Swierk wrote: > On Wed, Jul 22, 2009 at 11:38 PM, malc wrote: >> This is wrong on many levels. >> >> Suppose CLOCK_MONOTONIC(which is wrong _POSIX_MONOTONIC_CLOCK ought to= >> be checked) is defined and you compile your binary on, say, Linux 2.6 >> and then try to run it on 2.4 (without any fancy RHEL patches for >> instance), things wouldn't work, what's worse they wouldn't work >> silently, giving no indication what's wrong all because nobody checks >> clock_gettime result for failures. >> >> The CLOCK_MONOTONIC presence ought to be checked at runtime >> (see sysconf(3) and _POSIX_MONOTONIC_CLOCK) >=20 > OK, sounds like slirp should just call qemu_get_clock(rt_clock), which > is supposed to deal with all these complications. Exactly. Jan --------------enig96A16FBE99DD7971F00A5736 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpoBckACgkQniDOoMHTA+lUcwCdEZvEJ/Sm2WxclE8RdRY4YE6x kVQAniWM25vHXwz6HTbR0JF+hguSPOx9 =5Nib -----END PGP SIGNATURE----- --------------enig96A16FBE99DD7971F00A5736--