From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTs96-0006ga-VS for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:51:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTs92-0006dy-7n for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:51:16 -0400 Received: from [199.232.76.173] (port=50494 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTs92-0006do-3a for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:51:12 -0400 Received: from mx20.gnu.org ([199.232.41.8]:18956) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTs91-000783-Mz for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:51:11 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTs90-0002du-Ob for qemu-devel@nongnu.org; Thu, 23 Jul 2009 02:51:11 -0400 Message-ID: <4A68085D.8000600@web.de> Date: Thu, 23 Jul 2009 08:51:09 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1248313054.14831.36.camel@localhost.localdomain> <9ae48b020907221841q392c58b7k20f560f8a5e99fc2@mail.gmail.com> In-Reply-To: <9ae48b020907221841q392c58b7k20f560f8a5e99fc2@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig53A7E190901D9B26DCAD6CE0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] slirp: Remove our_addr code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ed Swierk Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig53A7E190901D9B26DCAD6CE0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Ed Swierk wrote: > On Thu, Jul 23, 2009 at 1:37 AM, Ed Swierk = wrote: >> - It's useless: aside from the CU-SeeMe protocol emulation which I >> propose removing, the only other reference is in get_dns_addr(), but >> can't imagine why you would want to send DNS requests to a different I= P >> address if you're running a DNS server on the host and resolv.conf >> points to 127.0.0.1. >> >> These problems are easily solved by removing the code. >=20 > Note that VirtualBox removed this code recently as well: > http://www.virtualbox.org/ticket/1470 . While I don't consider VirtualBox as a good reference for changing QEMU code ;), the patch has my conditional ack (depending on the CUSEEME emulation removal). Thanks for picking all this up! Jan --------------enig53A7E190901D9B26DCAD6CE0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpoCF0ACgkQniDOoMHTA+l5xgCcCS8ZfSLaFTKEC8KyIQZXdRag 3CoAnjq593XzxxE6Xoe2GKs0N8Zp3AIu =9U04 -----END PGP SIGNATURE----- --------------enig53A7E190901D9B26DCAD6CE0--