From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUIQ1-0003sx-1i for qemu-devel@nongnu.org; Fri, 24 Jul 2009 06:54:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUIPw-0003sk-4R for qemu-devel@nongnu.org; Fri, 24 Jul 2009 06:54:28 -0400 Received: from [199.232.76.173] (port=50978 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUIPv-0003sh-VH for qemu-devel@nongnu.org; Fri, 24 Jul 2009 06:54:24 -0400 Received: from gecko.sbs.de ([194.138.37.40]:20452) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MUIPu-0003zt-Rt for qemu-devel@nongnu.org; Fri, 24 Jul 2009 06:54:23 -0400 Message-ID: <4A69926A.2020005@siemens.com> Date: Fri, 24 Jul 2009 12:52:26 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1248384704-47824-1-git-send-email-agraf@suse.de> <1248384704-47824-2-git-send-email-agraf@suse.de> <1248384704-47824-3-git-send-email-agraf@suse.de> <1248384704-47824-4-git-send-email-agraf@suse.de> In-Reply-To: <1248384704-47824-4-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/3] PPC: Round VGA BIOS size to page boundary List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org Alexander Graf wrote: > When giving KVM a slot of a size not on page boundary, it chokes. So let's > just round up the VGA BIOS size so nobody complains anymore and we don't need > to implement sub-page slots. > > Required for booting a PPC guest in KVM. > > Signed-off-by: Alexander Graf > --- > hw/ppc_newworld.c | 3 +++ > hw/ppc_oldworld.c | 4 ++++ > 2 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c > index 4e5043c..b28a23d 100644 > --- a/hw/ppc_newworld.c > +++ b/hw/ppc_newworld.c > @@ -179,6 +179,9 @@ static void ppc_core99_init (ram_addr_t ram_size, > vga_bios_ptr[3] = 'V'; > cpu_to_be32w((uint32_t *)(vga_bios_ptr + 4), vga_bios_size); > vga_bios_size += 8; > + > + /* Round to page boundary */ > + vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) & TARGET_PAGE_MASK; To be really nit-picky: ;) (vga_bios_size + TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK; Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux