From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUWCd-0004u5-4M for qemu-devel@nongnu.org; Fri, 24 Jul 2009 21:37:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUWCY-0004ld-Lh for qemu-devel@nongnu.org; Fri, 24 Jul 2009 21:37:34 -0400 Received: from [199.232.76.173] (port=56445 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUWCY-0004lO-Ce for qemu-devel@nongnu.org; Fri, 24 Jul 2009 21:37:30 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37193) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MUWCX-0003VQ-SH for qemu-devel@nongnu.org; Fri, 24 Jul 2009 21:37:30 -0400 Message-ID: <4A6A61D4.1080807@redhat.com> Date: Sat, 25 Jul 2009 03:37:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1248466823-12707-1-git-send-email-glommer@redhat.com> In-Reply-To: <1248466823-12707-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] fix broken migration List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 07/24/2009 10:20 PM, Glauber Costa wrote: > While fixing migration with -S, commit > 89befdd1a6b18215153b8976682d57b7d03d5782 broke the rest of us. With this patch a migrated virtual machine will never be restarted. If you want that, shouldn't you use -S? But if you really wanted a migrated virtual machine to never be restarted, didn't you have a problem before my patch as well? Note that autostart (the variable) is never read except to choose whether to do that vm_start; so there can be no collateral effects from passing -S. I don't understand what this patch is trying to achieve (and why). Paolo