From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUe7N-0004Fx-63 for qemu-devel@nongnu.org; Sat, 25 Jul 2009 06:04:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUe7I-00047C-5Q for qemu-devel@nongnu.org; Sat, 25 Jul 2009 06:04:40 -0400 Received: from [199.232.76.173] (port=44820 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUe7I-00046u-0P for qemu-devel@nongnu.org; Sat, 25 Jul 2009 06:04:36 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:56985) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MUe7H-0004dN-7p for qemu-devel@nongnu.org; Sat, 25 Jul 2009 06:04:35 -0400 Message-ID: <4A6AD8AF.3080509@web.de> Date: Sat, 25 Jul 2009 12:04:31 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1248511217-22681-1-git-send-email-yu.liu@freescale.com> <1248511217-22681-2-git-send-email-yu.liu@freescale.com> <1248511217-22681-3-git-send-email-yu.liu@freescale.com> In-Reply-To: <1248511217-22681-3-git-send-email-yu.liu@freescale.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig402D273186A9A520CB0AD4DD" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 2/5] Fix booke registers init List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yu-B13201 Cc: kvm-ppc , Nathan Froyd , qemu-devel , Hollis Blanchard This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig402D273186A9A520CB0AD4DD Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Liu Yu wrote: > Commit 8d2ba1fb9c8e7006e10d71fa51a020977f14c8b0 > introduces a new new reset order. >=20 > So that we have to synchronize registers explicitly. >=20 > Signed-off-by: Liu Yu > --- > hw/ppc440_bamboo.c | 4 +++- > hw/ppce500_mpc8544ds.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c > index d9ef3ec..f1ba130 100644 > --- a/hw/ppc440_bamboo.c > +++ b/hw/ppc440_bamboo.c > @@ -182,8 +182,10 @@ static void bamboo_init(ram_addr_t ram_size, > /* XXX we currently depend on KVM to create some initial TLB e= ntries. */ > } > =20 > - if (kvm_enabled()) > + if (kvm_enabled()) { > + kvm_arch_put_registers(env); > kvmppc_init(); > + } > } > =20 > static QEMUMachine bamboo_machine =3D { > diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c > index c0e367d..f1b3c1a 100644 > --- a/hw/ppce500_mpc8544ds.c > +++ b/hw/ppce500_mpc8544ds.c > @@ -276,8 +276,10 @@ static void mpc8544ds_init(ram_addr_t ram_size, > /* XXX we currently depend on KVM to create some initial TLB e= ntries. */ > } > =20 > - if (kvm_enabled()) > + if (kvm_enabled()) { > + kvm_arch_put_registers(env); > kvmppc_init(); > + } > =20 > return; > } These are required when loading a device tree and, thus, changing some registers after cpu_init, right? Then please add cpu_synchronize_state(env, 1) to the corresponding code blocks instead of this explicit, kvm-specific loading. Jan --------------enig402D273186A9A520CB0AD4DD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpq2K8ACgkQniDOoMHTA+lQ0gCaA+g6+M7TZFrMZmHe+waOl6Gd jJsAniVePBhtH3quvHSkI6jJNSjYARvh =FZqJ -----END PGP SIGNATURE----- --------------enig402D273186A9A520CB0AD4DD--