From: Paolo Bonzini <bonzini@gnu.org>
To: malc <av1474@comtv.ru>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org,
Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define
Date: Sat, 25 Jul 2009 15:53:50 +0200 [thread overview]
Message-ID: <4A6B0E6E.6030600@gnu.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0907251512090.2755@linmac.oyster.ru>
On 07/25/2009 01:13 PM, malc wrote:
> On Fri, 24 Jul 2009, Juan Quintela wrote:
>
>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>> ---
>> audio/audio.c | 25 ++++++++++++++++++++++++-
>> configure | 3 ---
>> 2 files changed, 24 insertions(+), 4 deletions(-)
>
> That's how it used to be before, i see no reason of going back to this
> style.
Personally I prefer Juan's. It makes things more uniform; even though
for example I disagree on changing autoconfy HAVE_* defines to CONFIG_*,
it wouldn't be a problem at all to have CONFIG_* in qemu.
Paolo
next prev parent reply other threads:[~2009-07-25 13:54 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 18:30 [Qemu-devel] [PATCH v2 00/46] More configure/Makefile cleanups Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 01/46] change HOST_SOLARIS to CONFIG_SOLARIS{_VERSION} Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 02/46] Remove SP_CFLAGS and SP_LDFLAGS Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 03/46] target_arch2 is redefined unconditionally later Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 04/46] remove CONFIG_ from VNC_TLS_{LIBS, FLAGS} Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 05/46] use same algorithm for testing and Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 06/46] remove CONFIG_ from VNC_SASL_{LIBS, FLAGS} Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 07/46] remove CONFIG_ from BLUEZ_{LIBS,FLAGS} Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 08/46] make fmod also use FMOD_{LIBS,CFLAGS} Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 09/46] make oss use OSS_LIBS Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 10/46] move printing of config-host.mak variables to end of generation Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 11/46] more specific config.mak can overwrote more general config.mak Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 12/46] Add -static in configure if needed Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 13/46] Rename HAVE_FDT to CONFIG_FDT and define it also in Makefile Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 14/46] Refactor code to remove one #ifdef CONFIG_FDT Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 15/46] fix indententation Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 16/46] O_LARGEFILE is already set in qemu-common.h Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 17/46] rename HOST_BSD to CONFIG_BSD Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 18/46] define MAP_ANONYMOUS if it is not defined in qemu-common.h Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 19/46] rename HAVE_PREADV to CONFIG_PREADV Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 20/46] rename HAVE_IOVEC to CONFIG_IOVEC Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 21/46] rename HAVE_FNMATCH_H to CONFIG_FNMATCH Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H Juan Quintela
2009-07-24 20:46 ` Nathan Froyd
2009-07-24 21:10 ` [Qemu-devel] " Juan Quintela
2009-07-27 13:10 ` Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 23/46] rename HAVE_BYTESWAP_H to CONFIG_BYTESWAP_H Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 24/46] rename DEBUG_TCG to CONFIG_DEBUG_TCG Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 25/46] rename DEBUG_EXEC to CONFIG_DEBUG_EXEC Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 26/46] rename WORDS_BIGENDIAN to CONFIG_WORDS_BIGENDIAN Juan Quintela
2009-07-25 17:08 ` Blue Swirl
2009-07-27 12:59 ` [Qemu-devel] " Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 27/46] Add CONFIG_POSIX Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 28/46] Use CONFIG_POSIX to simplify Makefile Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 29/46] the else part of this test is obsolete We are testing for sdl = yes inside the else part of the test if sdl = yes Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 30/46] sdl_config value was always sdl-config Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 31/46] Calculate sdl_libs and sdl_flags and use them everywhere Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 32/46] instead of setup sdl_x11 just add -lX11 to sdl_libs Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 33/46] target_softmmu is undefined at that point Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 34/46] remove sdl_static. Just do the right thing if static is yes Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 35/46] indent with 2 spaces sdl tests Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 36/46] Define and use xen libs in a single place Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 37/46] simplify curses library selection Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 38/46] simplify brlapi selection Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 39/46] simplify vde libs selection Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 40/46] simplify fdt " Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 41/46] test if xen is enabled only once Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 42/46] define ENOTSUP the same that the other errors Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 43/46] rename NEEDS_LIBSUNMATH to CONFIG_NEEDS_LIBSUNMATH Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 44/46] rename USE_NPTL to CONFIG_USE_NPTL Juan Quintela
2009-07-24 18:30 ` [Qemu-devel] [PATCH 45/46] Remove AUDIO_DRIVERS define Juan Quintela
2009-07-25 11:13 ` malc
2009-07-25 13:53 ` Paolo Bonzini [this message]
2009-07-25 15:13 ` [Qemu-devel] " malc
2009-07-25 16:40 ` Paolo Bonzini
2009-07-25 18:57 ` Juan Quintela
2009-07-26 13:24 ` [Qemu-devel] " Anthony Liguori
2009-07-26 13:41 ` [Qemu-devel] " Juan Quintela
2009-07-26 14:43 ` Avi Kivity
2009-07-26 15:09 ` Jan Kiszka
2009-07-26 15:17 ` Avi Kivity
2009-07-26 18:21 ` malc
2009-07-26 18:26 ` Jan Kiszka
2009-07-26 20:42 ` malc
2009-07-26 19:36 ` Anthony Liguori
2009-07-26 19:31 ` Anthony Liguori
2009-07-24 18:30 ` [Qemu-devel] [PATCH 46/46] Generate config-host.h from config-host.mak Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6B0E6E.6030600@gnu.org \
--to=bonzini@gnu.org \
--cc=aliguori@us.ibm.com \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).