From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUhhJ-0004S0-Of for qemu-devel@nongnu.org; Sat, 25 Jul 2009 09:54:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUhhE-0004RH-9n for qemu-devel@nongnu.org; Sat, 25 Jul 2009 09:54:00 -0400 Received: from [199.232.76.173] (port=45349 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUhhE-0004R5-6C for qemu-devel@nongnu.org; Sat, 25 Jul 2009 09:53:56 -0400 Received: from mx20.gnu.org ([199.232.41.8]:9876) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MUhhD-0000RM-MI for qemu-devel@nongnu.org; Sat, 25 Jul 2009 09:53:55 -0400 Received: from mail-fx0-f224.google.com ([209.85.220.224]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MUhhC-0002Nv-KQ for qemu-devel@nongnu.org; Sat, 25 Jul 2009 09:53:54 -0400 Received: by fxm24 with SMTP id 24so1834212fxm.34 for ; Sat, 25 Jul 2009 06:53:52 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4A6B0E6E.6030600@gnu.org> Date: Sat, 25 Jul 2009 15:53:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Juan Quintela On 07/25/2009 01:13 PM, malc wrote: > On Fri, 24 Jul 2009, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela >> --- >> audio/audio.c | 25 ++++++++++++++++++++++++- >> configure | 3 --- >> 2 files changed, 24 insertions(+), 4 deletions(-) > > That's how it used to be before, i see no reason of going back to this > style. Personally I prefer Juan's. It makes things more uniform; even though for example I disagree on changing autoconfy HAVE_* defines to CONFIG_*, it wouldn't be a problem at all to have CONFIG_* in qemu. Paolo