[Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define

[Paolo Bonzini <bonzini@gnu.org>]

On 07/25/2009 05:13 PM, malc wrote:
> On Sat, 25 Jul 2009, Paolo Bonzini wrote:
>
>> On 07/25/2009 01:13 PM, malc wrote:
>>> On Fri, 24 Jul 2009, Juan Quintela wrote:
>>>
>>>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>>>> ---
>>>>    audio/audio.c |   25 ++++++++++++++++++++++++-
>>>>    configure     |    3 ---
>>>>    2 files changed, 24 insertions(+), 4 deletions(-)
>>> That's how it used to be before, i see no reason of going back to this
>>> style.
>> Personally I prefer Juan's.  It makes things more uniform; even though for
>> example I disagree on changing autoconfy HAVE_* defines to CONFIG_*, it
>> wouldn't be a problem at all to have CONFIG_* in qemu.
>
> For starters this is not a functional equivalent of the things currently
> in place, please read the commit message of: 0c58ac1c7

You're right.

Paolo