From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MUkIt-0002CF-UU
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 12:41:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MUkIp-00026w-As
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 12:40:59 -0400
Received: from [199.232.76.173] (port=40983 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MUkIp-00026t-6T
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 12:40:55 -0400
Received: from mail-fx0-f224.google.com ([209.85.220.224]:37826)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MUkIo-0006YT-LH
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 12:40:54 -0400
Received: by fxm24 with SMTP id 24so1877699fxm.34
	for <qemu-devel@nongnu.org>; Sat, 25 Jul 2009 09:40:53 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4A6B3593.8050608@gnu.org>
Date: Sat, 25 Jul 2009 18:40:51 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <cover.1248459711.git.quintela@redhat.com>	<e6be06cdb99207d831add2722e4c4f20a45d06b9.1248459711.git.quintela@redhat.com>	<Pine.LNX.4.64.0907251512090.2755@linmac.oyster.ru>	<4A6B0E6E.6030600@gnu.org>
	<Pine.LNX.4.64.0907251911540.2172@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0907251911540.2172@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On 07/25/2009 05:13 PM, malc wrote:
> On Sat, 25 Jul 2009, Paolo Bonzini wrote:
>
>> On 07/25/2009 01:13 PM, malc wrote:
>>> On Fri, 24 Jul 2009, Juan Quintela wrote:
>>>
>>>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>>>> ---
>>>>    audio/audio.c |   25 ++++++++++++++++++++++++-
>>>>    configure     |    3 ---
>>>>    2 files changed, 24 insertions(+), 4 deletions(-)
>>> That's how it used to be before, i see no reason of going back to this
>>> style.
>> Personally I prefer Juan's.  It makes things more uniform; even though for
>> example I disagree on changing autoconfy HAVE_* defines to CONFIG_*, it
>> wouldn't be a problem at all to have CONFIG_* in qemu.
>
> For starters this is not a functional equivalent of the things currently
> in place, please read the commit message of: 0c58ac1c7

You're right.

Paolo