From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MV3iH-0004a6-Se for qemu-devel@nongnu.org; Sun, 26 Jul 2009 09:24:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MV3iB-0004Ss-Ai for qemu-devel@nongnu.org; Sun, 26 Jul 2009 09:24:27 -0400 Received: from [199.232.76.173] (port=50773 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MV3iB-0004Sp-3J for qemu-devel@nongnu.org; Sun, 26 Jul 2009 09:24:23 -0400 Received: from mail-gx0-f220.google.com ([209.85.217.220]:50731) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MV3iA-0004Aj-HI for qemu-devel@nongnu.org; Sun, 26 Jul 2009 09:24:22 -0400 Received: by gxk20 with SMTP id 20so12117161gxk.10 for ; Sun, 26 Jul 2009 06:24:21 -0700 (PDT) Message-ID: <4A6C5903.4000708@codemonkey.ws> Date: Sun, 26 Jul 2009 08:24:19 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 45/46] Remove AUDIO_DRIVERS define References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Juan Quintela malc wrote: > On Fri, 24 Jul 2009, Juan Quintela wrote: > > >> Signed-off-by: Juan Quintela >> --- >> audio/audio.c | 25 ++++++++++++++++++++++++- >> configure | 3 --- >> 2 files changed, 24 insertions(+), 4 deletions(-) >> > > That's how it used to be before, i see no reason of going back to this > style. > Right. The way to get rid of AUDIO_DRIVERS is to convert drvtab[] to be a list with an appropriate audio driver registration function. Each .c file should have an audio_init() method that then registers the audio_driver structure. Individual audio drivers can be added/removed by simply building or not building the file. Just like how the block infrastructure works. Regards, Anthony Liguori > [..snip..] > >