From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MV5PJ-0003Yq-KS for qemu-devel@nongnu.org; Sun, 26 Jul 2009 11:13:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MV5PF-0003YX-7E for qemu-devel@nongnu.org; Sun, 26 Jul 2009 11:13:01 -0400 Received: from [199.232.76.173] (port=60901 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MV5PF-0003YU-1l for qemu-devel@nongnu.org; Sun, 26 Jul 2009 11:12:57 -0400 Received: from mx2.redhat.com ([66.187.237.31]:47187) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MV5PE-00035O-Kj for qemu-devel@nongnu.org; Sun, 26 Jul 2009 11:12:56 -0400 Message-ID: <4A6C7372.8050908@redhat.com> Date: Sun, 26 Jul 2009 18:17:06 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4A6C5903.4000708@codemonkey.ws> <4A6C6B9C.2080909@redhat.com> <4A6C71A2.70904@web.de> In-Reply-To: <4A6C71A2.70904@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Juan Quintela On 07/26/2009 06:09 PM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 07/26/2009 04:41 PM, Juan Quintela wrote: >> >>> The order in audio_drivers is important, that means you can have a >>> different default sound driver. >>> >>> After some thinking, my current plan is exporting audio_drv_list >>> to the Makefile, and then generating something similar to AUDIO_DRIVERS. >>> >>> Notice that the "ordering" problems not only happens with sound drivers, >>> we have the same problems with graphics console, which one is the >>> default one? It depends on what you have configured, and changing the >>> default order is far from trivial. >>> >>> >> You could pass a goodness value to the registration function, reflecting >> what we think the best driver is. Then at runtime select the best >> driver that is supported on the system. >> >> > > I think the easiest way is to forward the sorted driver list as string > to the audio layer and let it be processed there. Given such an > extension, we could also allow passing a list of drivers via QEMU_AUDIO_DRV. > Yes, that is better. Decouple the goodness from the driver, and allow the user to override it. > BTW, I still wonder why we have OSS and only OSS as the default driver > list under Linux. Most distros I came across kicked it out or pushed it > to the end of their list (as it requires exclusive access). Would be a > chance to improve the default. At least we should extend the list by all > available drivers. > > I have some secondhand memories of pulse and alsa generating very bad output. -- error compiling committee.c: too many arguments to function