From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVKZd-00073G-Hw for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:24:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVKZZ-000734-1z for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:24:41 -0400 Received: from [199.232.76.173] (port=55811 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVKZY-000731-Pz for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:24:36 -0400 Received: from mx20.gnu.org ([199.232.41.8]:11448) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVKZY-0001hN-EZ for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:24:36 -0400 Received: from relay1.sgi.com ([192.48.179.29] helo=relay.sgi.com) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVKZW-0005jw-Sj for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:24:35 -0400 Message-ID: <4A6D562C.3010103@sgi.com> Date: Mon, 27 Jul 2009 09:24:28 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <4A69B200.3030500@sgi.com> <20090725015649.GA15207@morn.localdomain> In-Reply-To: <20090725015649.GA15207@morn.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Seabios irq override support. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Beth Kon , qemu-devel On 07/25/2009 03:56 AM, Kevin O'Connor wrote: > On Fri, Jul 24, 2009 at 03:07:12PM +0200, Jes Sorensen wrote: >> With this patch applied, I can boot KVM using the latest upstream QEMU >> and Seabios. > > Thanks Jes. > > The bochs commit shows this wrapped in "#ifdef BX_QEMU". Will this > patch break bochs, or were the ifdefs just bochs paranoia? Hi Kevin, I don't actually know for sure. I didn't add the #ifdefs since I got the impression that Seabios doesn't have them in many places. The original code was designed by Beth Kon, so maybe she can comment on whether we should add them to Seabios. Beth? Thanks, Jes