From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVQqX-0007K2-3d
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:06:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVQqR-0007IR-7p
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:06:31 -0400
Received: from [199.232.76.173] (port=42520 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVQqQ-0007IB-I7
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:06:26 -0400
Received: from mail.windriver.com ([147.11.1.11]:56804 helo=mail.wrs.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jason.wessel@windriver.com>) id 1MVQqP-0007Al-QF
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:06:26 -0400
Message-ID: <4A6DB447.7030001@windriver.com>
Date: Mon, 27 Jul 2009 09:05:59 -0500
From: Jason Wessel <jason.wessel@windriver.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH, RFC] Sparc64: convert APB to qdev
References: <f43fc5580907200326r793e4f9am2db06ce0bd7dce1b@mail.gmail.com>
	<b2fa41d60907201419k121d5c2fr274db4fbec2cc01c@mail.gmail.com>
	<f43fc5580907210045pcefff74s5d3ab770b920dd95@mail.gmail.com>
In-Reply-To: <f43fc5580907210045pcefff74s5d3ab770b920dd95@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

Blue Swirl wrote:
> On Tue, Jul 21, 2009 at 12:19 AM, Igor
> Kovalenko<igor.v.kovalenko@gmail.com> wrote:
>   
>> On Mon, Jul 20, 2009 at 2:26 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>>     
>>> I have a problem with APB conversion to qdev. For some reason, with
>>> the patch applied, PCI config register access changes and OpenBIOS
>>> can't find any PCI devices.
>>>       
>> You are using pci_host_data_* which expects opaque pointer to PCIHostState,
>> so you need to pass appropriate opaque to cpu_register_io_memory.
>> With this small amendment I verified there are no changes to qemu.log and
>> serial console output.
>>     
>
> Great, thanks!
>
>   
>> Not sure if this requires sign-off :)
>>     
>
> Good question, perhaps the SoB experts should clarify the policy.
>
> But in this case it makes no sense to commit my broken version and
> then your patch. I think I'll just give you credit in the message for
> the fixed commit.
>
>   

If you are looking for some kind of standard to follow based on the
linux kernel use, the document is:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;hb=HEAD

The example given shows a maintainer cleaning up someone else's patch
for merge.

347
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=5c555a8b39e553cf0c3117026ebf37d481c588b6;hb=HEAD#l347>
        Signed-off-by: Random J Developer <random@developer.example.org>
348
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=5c555a8b39e553cf0c3117026ebf37d481c588b6;hb=HEAD#l348>
        [lucky@maintainer.example.org: struct foo moved from foo.c to foo.h]
349
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=5c555a8b39e553cf0c3117026ebf37d481c588b6;hb=HEAD#l349>
        Signed-off-by: Lucky K Maintainer <lucky@maintainer.example.org>

The pattern is no different if you fold 1 or more patches together.  The
credit can go in the bracket section.

Akpm does this a lot if you wanted to search the linux kernel for any
other examples.
linux-2.6.git % git log |grep "\[akpm" |wc -l
1276


Cheers,
Jason.