[Qemu-devel] Re: [PATCH] fix endless look at kvm migration

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

Glauber Costa wrote:
> If we try to sync bitmaps withouth KVM_MEM_LOG_DIRTY_PAGES being set
> on a slot, we will enter an endless loop. Remove the test, since it
> is not strictly needed anyway
> 
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> CC: Alexander Graf <agraf@suse.de>
> ---
>  kvm-all.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index 824bb4c..d3bbd3c 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -331,11 +331,6 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
>              break;
>          }
>  
> -        /* We didn't activate dirty logging? Don't care then. */
> -        if(!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES)) {
> -            continue;
> -        }
> -
>          size = ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8;
>          if (!d.dirty_bitmap) {
>              d.dirty_bitmap = qemu_malloc(size);

Please let us revert the whole bd83677.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]