From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVVCa-0007Wm-KT
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:45:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVVCV-0007Uk-Lj
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:45:36 -0400
Received: from [199.232.76.173] (port=46362 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVVCV-0007Uf-Hj
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:45:31 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:55206)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MVVCU-0003pa-SK
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:45:31 -0400
Message-ID: <4A6DF5AB.6000608@web.de>
Date: Mon, 27 Jul 2009 20:44:59 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <1248719202-24401-1-git-send-email-glommer@redhat.com>
In-Reply-To: <1248719202-24401-1-git-send-email-glommer@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig0B92C90B81DDB83B21AEB849"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] fix endless look at kvm migration
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig0B92C90B81DDB83B21AEB849
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Glauber Costa wrote:
> If we try to sync bitmaps withouth KVM_MEM_LOG_DIRTY_PAGES being set
> on a slot, we will enter an endless loop. Remove the test, since it
> is not strictly needed anyway
>=20
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> CC: Alexander Graf <agraf@suse.de>
> ---
>  kvm-all.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>=20
> diff --git a/kvm-all.c b/kvm-all.c
> index 824bb4c..d3bbd3c 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -331,11 +331,6 @@ int kvm_physical_sync_dirty_bitmap(target_phys_add=
r_t start_addr,
>              break;
>          }
> =20
> -        /* We didn't activate dirty logging? Don't care then. */
> -        if(!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES)) {
> -            continue;
> -        }
> -
>          size =3D ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8;
>          if (!d.dirty_bitmap) {
>              d.dirty_bitmap =3D qemu_malloc(size);

Please let us revert the whole bd83677.

Jan


--------------enig0B92C90B81DDB83B21AEB849
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkpt9a8ACgkQniDOoMHTA+nKTQCbB47MLDT/eK/3ydcnBen6zJ5F
J5QAnA8qyqWqRRoB0GZJiyawWku7y+9E
=LxM4
-----END PGP SIGNATURE-----

--------------enig0B92C90B81DDB83B21AEB849--