From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVVLL-0002fT-5K for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:54:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVVLG-0002cs-F2 for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:54:38 -0400 Received: from [199.232.76.173] (port=35040 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVVLG-0002cl-5X for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:54:34 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:59253) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVVLF-00067H-El for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:54:33 -0400 Message-ID: <4A6DF759.9080201@web.de> Date: Mon, 27 Jul 2009 20:52:09 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1248719202-24401-1-git-send-email-glommer@redhat.com> <4A6DF5AB.6000608@web.de> <17CC828E-F007-4BE7-B66B-7A24E6305ABE@suse.de> In-Reply-To: <17CC828E-F007-4BE7-B66B-7A24E6305ABE@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5DE9EFAE587ADA1A92D4DCA0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] fix endless look at kvm migration List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Glauber Costa , qemu-devel@nongnu.org, aliguori@us.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5DE9EFAE587ADA1A92D4DCA0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Alexander Graf wrote: >=20 > On 27.07.2009, at 20:44, Jan Kiszka wrote: >=20 >> Glauber Costa wrote: >>> If we try to sync bitmaps withouth KVM_MEM_LOG_DIRTY_PAGES being set >>> on a slot, we will enter an endless loop. Remove the test, since it >>> is not strictly needed anyway >>> >>> Signed-off-by: Glauber Costa >>> CC: Alexander Graf >>> --- >>> kvm-all.c | 5 ----- >>> 1 files changed, 0 insertions(+), 5 deletions(-) >>> >>> diff --git a/kvm-all.c b/kvm-all.c >>> index 824bb4c..d3bbd3c 100644 >>> --- a/kvm-all.c >>> +++ b/kvm-all.c >>> @@ -331,11 +331,6 @@ int >>> kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr, >>> break; >>> } >>> >>> - /* We didn't activate dirty logging? Don't care then. */ >>> - if(!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES)) { >>> - continue; >>> - } >>> - >>> size =3D ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8; >>> if (!d.dirty_bitmap) { >>> d.dirty_bitmap =3D qemu_malloc(size); >> >> Please let us revert the whole bd83677. >=20 > Does the non-functional if (r < 0) hurt anyone? I would reduce the motivation of the next kvm-arch contributor to implement proper dirty log tracking. :) >=20 > But if you like cleaniness, yes - reverting the whole thing would be > fine with me too. >=20 There are no users for this in sight, so it's best the clean it up - and then fix the error check that this discussion has revealed. Jan --------------enig5DE9EFAE587ADA1A92D4DCA0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpt91kACgkQniDOoMHTA+m2SwCePTex9EqmiFwB7gNcZZvmxB69 L9oAn1KYF60pdLCDgvj1ch5y4JvL+l5B =amfq -----END PGP SIGNATURE----- --------------enig5DE9EFAE587ADA1A92D4DCA0--