From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVVvO-0003tA-Si for qemu-devel@nongnu.org; Mon, 27 Jul 2009 15:31:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVVvK-0003sg-Hu for qemu-devel@nongnu.org; Mon, 27 Jul 2009 15:31:54 -0400 Received: from [199.232.76.173] (port=51906 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVVvK-0003sY-9Y for qemu-devel@nongnu.org; Mon, 27 Jul 2009 15:31:50 -0400 Received: from mx20.gnu.org ([199.232.41.8]:52003) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVVvJ-00084W-V8 for qemu-devel@nongnu.org; Mon, 27 Jul 2009 15:31:50 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVVvI-0000rs-KG for qemu-devel@nongnu.org; Mon, 27 Jul 2009 15:31:48 -0400 Message-ID: <4A6E009F.8010608@redhat.com> Date: Mon, 27 Jul 2009 21:31:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1248466823-12707-1-git-send-email-glommer@redhat.com> <4A6A61D4.1080807@redhat.com> <20090727180218.GF4776@poweredge.glommer> In-Reply-To: <20090727180218.GF4776@poweredge.glommer> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] fix broken migration List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 07/27/2009 08:02 PM, Glauber Costa wrote: > If I pass --incoming to the VM, I don't expect the VM to start. I expect it > to wait, because I'll be handling it a migration later. However, it does start, > which is clearly wrong. I see now, thanks. I was puzzled by your message, so to speak. I suppose the best semantics would be to do like if (autostart && !incoming) vm_start () in vl.c and add if (autostart) vm_start () in the migration-*.c files. Paolo