From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVZD1-0004qj-JY
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 19:02:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVZCw-0004pX-3s
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 19:02:18 -0400
Received: from [199.232.76.173] (port=36657 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVZCw-0004pU-0Z
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 19:02:14 -0400
Received: from e4.ny.us.ibm.com ([32.97.182.144]:55311)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1MVZCv-0006U9-GZ
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 19:02:13 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e4.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n6RMuLU7003020
	for <qemu-devel@nongnu.org>; Mon, 27 Jul 2009 18:56:21 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n6RN2CUE216052
	for <qemu-devel@nongnu.org>; Mon, 27 Jul 2009 19:02:12 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n6RMxVjP025132
	for <qemu-devel@nongnu.org>; Mon, 27 Jul 2009 18:59:31 -0400
Message-ID: <4A6E31EF.6050504@us.ibm.com>
Date: Mon, 27 Jul 2009 18:02:07 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove
	INIT_FIELD() macro
References: <cover.1248726105.git.quintela@redhat.com>
	<874e96d24ad01cfaf930a55ed96119d3f5e2da53.1248726105.git.quintela@redhat.com>
	<Pine.LNX.4.64.0907280101390.3551@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0907280101390.3551@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

malc wrote:
> On Mon, 27 Jul 2009, Juan Quintela wrote:
>
> This patch is pointless.
>   

The INIT_FIELD() stuff is goofy.  struct initializers are C99 so using 
them conditionally on GNUC is incorrect.  Also, if you can't rely on the 
initializier, what's the point of even doing it at all since you cannot 
change order.

Removing INIT_FIELD() is a big improvement IMHO.

-- 
Regards,

Anthony Liguori