From: Gerd Hoffmann <kraxel@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 3/4] Use C99 initializers for audio_option
Date: Tue, 28 Jul 2009 10:03:53 +0200 [thread overview]
Message-ID: <4A6EB0E9.40704@redhat.com> (raw)
In-Reply-To: <m3iqhdsr81.fsf@neno.mitica>
On 07/28/09 00:20, Juan Quintela wrote:
> malc<av1474@comtv.ru> wrote:
>> On Mon, 27 Jul 2009, Juan Quintela wrote:
>>
>> I'd prefer:
>>
>> { .name = "DAC_SIZE_IN_USEC",
>> .tag = AUD_OPT_BOOL,
>> .valp =&conf.size_in_usec_out,
>> .descr = "DAC period/buffer size in microseconds (otherwise in frames)" },
>> { ...
>>
>> And likewise elsewhere.
>
> I tried to be consistent with the qdev patches, they add all its "arrays
> of structures" this way (it is one of the bigger users of the feature
> that I saw).
I think malc refers to the vertical alignment, i.e.
.foo = bar,
.longname = somethingelse,
instead of
.foo = bar,
.longname = somethingelse,
The version with the vertical aligned '=' is more readable IMO.
cheers,
Gerd
next prev parent reply other threads:[~2009-07-28 8:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 20:23 [Qemu-devel] [PATCH 0/4] Use C99 struct initializers in audio/* Juan Quintela
2009-07-27 20:23 ` [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro Juan Quintela
2009-07-27 21:03 ` malc
2009-07-27 21:07 ` Anthony Liguori
2009-07-27 22:57 ` [Qemu-devel] " Paolo Bonzini
2009-07-27 23:02 ` [Qemu-devel] " Anthony Liguori
2009-07-28 16:54 ` malc
2009-07-28 17:13 ` [Qemu-devel] " Juan Quintela
2009-07-28 17:23 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 2/4] use C99 initializers for audio_pcm_ops Juan Quintela
2009-07-27 21:07 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 3/4] Use C99 initializers for audio_option Juan Quintela
2009-07-27 21:10 ` malc
2009-07-27 22:20 ` [Qemu-devel] " Juan Quintela
2009-07-28 8:03 ` Gerd Hoffmann [this message]
2009-07-28 8:22 ` Juan Quintela
2009-07-28 16:48 ` malc
2009-07-28 17:23 ` Juan Quintela
2009-07-28 17:39 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 4/4] use C99 initializers for all audio/* Juan Quintela
2009-07-27 21:11 ` malc
2009-07-27 20:30 ` [Qemu-devel] Re: [PATCH 0/4] Use C99 struct initializers in audio/* Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6EB0E9.40704@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).