From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVhfZ-0001MT-OO
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 04:04:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVhfV-0001MG-PU
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 04:04:21 -0400
Received: from [199.232.76.173] (port=60698 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVhfV-0001MA-H4
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 04:04:17 -0400
Received: from mx20.gnu.org ([199.232.41.8]:25349)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1MVhfU-0003JL-Tf
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 04:04:17 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MVhfT-0006uk-Fd
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 04:04:15 -0400
Message-ID: <4A6EB0E9.40704@redhat.com>
Date: Tue, 28 Jul 2009 10:03:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 3/4] Use C99 initializers for audio_option
References: <cover.1248726105.git.quintela@redhat.com>	<b4fdbc11fa13fab7899b166b64156be0ba743e64.1248726105.git.quintela@redhat.com>	<Pine.LNX.4.64.0907280107590.3551@linmac.oyster.ru>
	<m3iqhdsr81.fsf@neno.mitica>
In-Reply-To: <m3iqhdsr81.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 07/28/09 00:20, Juan Quintela wrote:
> malc<av1474@comtv.ru>  wrote:
>> On Mon, 27 Jul 2009, Juan Quintela wrote:
>>
>> I'd prefer:
>>
>>         { .name  = "DAC_SIZE_IN_USEC",
>>           .tag   = AUD_OPT_BOOL,
>>           .valp  =&conf.size_in_usec_out,
>>           .descr = "DAC period/buffer size in microseconds (otherwise in frames)" },
>>         { ...
>>
>> And likewise elsewhere.
>
> I tried to be consistent with the qdev patches, they add all its "arrays
> of structures" this way (it is one of the bigger users of the feature
> that I saw).

I think malc refers to the vertical alignment, i.e.

   .foo      = bar,
   .longname = somethingelse,

instead of

   .foo = bar,
   .longname = somethingelse,

The version with the vertical aligned '=' is more readable IMO.

cheers,
   Gerd