From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVoPs-0003yl-Tn for qemu-devel@nongnu.org; Tue, 28 Jul 2009 11:16:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVoPr-0003yG-QY for qemu-devel@nongnu.org; Tue, 28 Jul 2009 11:16:36 -0400 Received: from [199.232.76.173] (port=45388 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVoPr-0003yA-Kl for qemu-devel@nongnu.org; Tue, 28 Jul 2009 11:16:35 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:36272) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVoPr-0007vU-8J for qemu-devel@nongnu.org; Tue, 28 Jul 2009 11:16:35 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e3.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6SFAYvC015658 for ; Tue, 28 Jul 2009 11:10:34 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6SFGXV1250346 for ; Tue, 28 Jul 2009 11:16:33 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6SFGWnt030014 for ; Tue, 28 Jul 2009 11:16:33 -0400 Message-ID: <4A6F1670.6040109@us.ibm.com> Date: Tue, 28 Jul 2009 11:17:04 -0400 From: Beth Kon MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090506090501050900020900" Subject: [Qemu-devel] [Fwd: Re: [PATCH] Seabios irq override support.] List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Jes Sorensen , Kevin O'Connor This is a multi-part message in MIME format. --------------090506090501050900020900 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Trying one more time... --------------090506090501050900020900 Content-Type: message/rfc822; name="Re: [PATCH] Seabios irq override support..eml" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Re: [PATCH] Seabios irq override support..eml" Message-ID: <4A6EFEC9.60602@us.ibm.com> Date: Tue, 28 Jul 2009 09:36:09 -0400 From: Beth Kon User-Agent: Thunderbird 2.0.0.22 (X11/20090608) MIME-Version: 1.0 To: Jes Sorensen CC: Kevin O'Connor , qemu-devel Subject: Re: [PATCH] Seabios irq override support. References: <4A69B200.3030500@sgi.com> <20090725015649.GA15207@morn.localdomain> <4A6D562C.3010103@sgi.com> <4A6DF629.1030802@us.ibm.com> <4A6EBDDE.2080409@sgi.com> In-Reply-To: <4A6EBDDE.2080409@sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Jes Sorensen wrote: > On 07/27/2009 08:47 PM, Beth Kon wrote: >> Hi Jes. These bios changes rely on matching userspace/kernel changes >> that translate irq0->inti2. So assuming seabios is used for systems >> other than kvm and qemu, this code would need to be conditionally >> removed. > > Hi Beth, > > Thanks for the input. I guess we'll want it to be CONFIG_KVM for now > then, since Seabios doesn't know of BX_QEMU. Once we have more of the > cfg_fw stuff needed for this, the #ifdef part can be made prettier. > >> But I'm not clear on what you're doing with this patch. You didn't >> include the irq0override flag that is needed by kvm because there are >> circumstances under which kvm turns off irq0override (i.e., old kernels >> that don't support irq routing). So this patch is fine for qemu, since >> it is permanently enabled there, but it is not a permanent solution for >> kvm. > > The reason I didn't include the irq0override flag is that the fw_cfg > bits for this aren't in Seabios yet. I'll be happy to add them in a > follow up patch. > > How do you like this version? It's a little more complex as I introduced > the irq0override variable, but it will make it very easy to add the > cfg_fw stuff. > > Cheers, > Jes Hi Jes. This patch looks fine. As we discussed on IRC, seabios with this patch won't work with old kernels that don't support gsi routing, but once you add the capability to control irq0override from userspace, that will be corrected. --------------090506090501050900020900--