Re: [Qemu-devel] bug report + fix: e1000.c in 0.10.5 does not properly emulate real hardware

[Anthony Liguori <anthony@codemonkey.ws>]

Bill Paul wrote:
> Let me make sure I understand correctly.
>
> You must have my previous e-mail with the patch in front of you, with the 
> attached unified diff. Are you saying that rather than just taking that 
> unidiff, from the e-mail I already sent, you want me to send you exactly the 
> same file, only with a different subject line that starts with [PATCH]?
>   

Yes.

> I'd like to point out that a) while this may be part of some standardized 
> project etiquette, I've yet to see these required steps clearly spelled out 
> anywhere,

Yes, we're definitely overdue for a SubmittingPatches file to live in 
the tree.  I suggested that you follow these steps not due to any sort 
of desire to follow arbitrary procedures but because it guarantees your 
patch will get attention.

>  and b) why can't you just take the diff I already sent and 
> apply/test/molest/etc it now that you have it?
>   

Well first, it's against 0.10.5 which means there's nothing to apply it 
to.  It has to be against our development tree.  Second, a system scales 
better when you push work down to the outer most nodes.  It's easier for 
to have you resubmit a patch and have everyone follow the same 
procedures than to have me manually extract individual patches from 
random threads, tweak them to apply to git, etc.

Regards,

Anthony Liguori