From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MW5iE-0008Hz-H1
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 05:44:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MW5iA-0008Gz-OL
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 05:44:42 -0400
Received: from [199.232.76.173] (port=51885 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MW5iA-0008Gu-Gw
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 05:44:38 -0400
Received: from mx2.redhat.com ([66.187.237.31]:38017)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MW5i9-0006fD-TO
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 05:44:38 -0400
Message-ID: <4A701B1F.9040900@redhat.com>
Date: Wed, 29 Jul 2009 12:49:19 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com>
	<1248818713-11261-2-git-send-email-lcapitulino@redhat.com>
	<4A701AA3.4060902@redhat.com>
In-Reply-To: <4A701AA3.4060902@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, qemu-devel@nongnu.org

On 07/29/2009 12:47 PM, Avi Kivity wrote:
>
>> +
>> +struct qemu_dict *qemu_dict_create(void);
>> +void qemu_dict_add(struct qemu_dict *qdict, const char *key, void 
>> *value);
>> +void *qemu_dict_get(const struct qemu_dict *qdict, const char *key);
>> +int qemu_dict_exists(const struct qemu_dict *qdict, const char *key);
>> +void *qemu_dict_del(struct qemu_dict *qdict, const char *key);
>> +void qemu_dict_destroy(struct qemu_dict *qdict);
>> +void qemu_dict_walk(const struct qemu_dict *qdict,
>> +                    void (*walkf)(const char *key, void *value));
>> +
>
> I'm worried about all those void *s as they move responsibility for 
> type safety and lifecycle management to the user.  I'd much rather see 
> a QObject (or Object) with the following methods:
>
>   clone() - deep copy an object; dicts will store copies so we'll 
> avoid those leaks or a dictionary member modified after it was stored
>   destroy()
>   type() - return the type
>   as_dict(), as_string(), as_int() - convert to a subclass so its 
> methods can be used
>
> Consider an operation such as printing out the dictionary, you have to 
> know the types of the values.
>

Note, if we decide we want this it could be introduced later to avoid 
excessive churn on this patchset.

-- 
error compiling committee.c: too many arguments to function