From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MW9IA-0000C4-LZ for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:34:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MW9I5-00009i-W6 for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:34:02 -0400 Received: from [199.232.76.173] (port=50894 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MW9I5-00009X-Qy for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:33:57 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42333) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MW9I5-0007qd-AJ for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:33:57 -0400 Message-ID: <4A7050DB.2010207@redhat.com> Date: Wed, 29 Jul 2009 16:38:35 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/25] Introduce QEMU dictionary data type References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> <1248818713-11261-2-git-send-email-lcapitulino@redhat.com> <20090729102835.3e2b546b@doriath> In-Reply-To: <20090729102835.3e2b546b@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, qemu-devel@nongnu.org On 07/29/2009 04:28 PM, Luiz Capitulino wrote: > >>> +static void *__qemu_dict_get(const struct qemu_dict *qdict, >>> + const char *key, unsigned int hash) >>> >> Do not violate the standard please. >> > > What's the problem, the '__' or the indentation? > The __ prefix is reserved for system identifiers. -- error compiling committee.c: too many arguments to function